Skip to content

Fix composer placeholder selection - #107

Merged
suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/composer-placeholder-selection
Jun 17, 2026
Merged

Fix composer placeholder selection#107
suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/composer-placeholder-selection

Conversation

@suguanYang

Copy link
Copy Markdown
Contributor

Summary

  • Hide the composer placeholder mirror while native textarea selection is active so selected text is not drawn twice.
  • Select the first bracket placeholder after inserting an expert prompt template so users can immediately type the replacement value.
  • Select the whole bracket placeholder when the caret lands inside it, making one-click replacement easier.

Validation

  • pnpm exec vitest run src/components/chat-composer.test.ts src/components/chat-panel.test.ts --reporter=verbose
  • pnpm exec eslint src/components/chat-composer.tsx src/components/chat-composer.test.ts
  • pnpm exec tsc --noEmit --pretty false
  • git diff --check origin/staging...HEAD
  • pnpm build

@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
knowhere-notebook-staging Ready Ready Preview, Comment Jun 17, 2026 6:47am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
knowhere-notebook Ignored Ignored Jun 17, 2026 6:47am

Request Review

@suguanYang
suguanYang merged commit 38535b8 into staging Jun 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant